[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] target-ppc: POWER8 supports the MSR_LE bit
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] target-ppc: POWER8 supports the MSR_LE bit |
Date: |
Thu, 27 Mar 2014 15:58:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 25.03.2014 08:29, schrieb Alex Bennée:
>
> Anton Blanchard <address@hidden> writes:
>
>> Add MSR_LE to the msr_mask for POWER8.
>>
> <snip>
>> - pcc->msr_mask = 0x800000000284FF36ULL;
>> + pcc->msr_mask = 0x800000000284FF37ULL;
> <snip>
>
> Should we be adding some #define's for the various bit positions on this
> mask? Looking at the current code it looks like a big ream of magic
> numbers.
In general I concur that defines would be nice, however for 2.0 that's
too risky for me as temporary maintainer and I'm not sure if these
values are being pieced together by contributors or whether this is
coming directly from the manual?
The other issue has been that adding a new family, even after the
initial round of cleanups, still requires a chunk of code to be copied,
which seems prone to forgetting little bits on the new one, then maybe
fixing up the original template but not the derived models, etc.
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 1/6] target-ppc: POWER8 supports the MSR_LE bit, Anton Blanchard, 2014/03/24
- [Qemu-devel] [PATCH 2/6] target-ppc: POWER8 supports isel, Anton Blanchard, 2014/03/24
- [Qemu-devel] [PATCH 5/6] target-ppc: Fix Book3S PMU SPRs, Anton Blanchard, 2014/03/24
- [Qemu-devel] [PATCH 4/6] target-ppc: MSR_POW not supported on POWER7/7+/8, Anton Blanchard, 2014/03/24
- [Qemu-devel] [PATCH 6/6] target-ppc: Add PMC7/8 to 970, Anton Blanchard, 2014/03/24
- [Qemu-devel] [PATCH 3/6] target-ppc: POWER7+ supports the MSR_VSX bit, Anton Blanchard, 2014/03/24
- Re: [Qemu-devel] [PATCH 1/6] target-ppc: POWER8 supports the MSR_LE bit, Alex Bennée, 2014/03/25
- Re: [Qemu-devel] [PATCH 1/6] target-ppc: POWER8 supports the MSR_LE bit,
Andreas Färber <=
- Re: [Qemu-devel] [PATCH 1/6] target-ppc: POWER8 supports the MSR_LE bit, Andreas Färber, 2014/03/27