qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 12/23] hw/pci/pci_host.c: Avoid shifting left into si


From: Michael Tokarev
Subject: [Qemu-devel] [PULL 12/23] hw/pci/pci_host.c: Avoid shifting left into sign bit
Date: Thu, 27 Mar 2014 19:28:17 +0400

From: Peter Maydell <address@hidden>

Add U suffix to avoid undefined behaviour.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
 hw/pci/pci_host.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c
index 77c7d1f..3e26f92 100644
--- a/hw/pci/pci_host.c
+++ b/hw/pci/pci_host.c
@@ -142,8 +142,9 @@ static uint64_t pci_host_data_read(void *opaque,
 {
     PCIHostState *s = opaque;
     uint32_t val;
-    if (!(s->config_reg & (1 << 31)))
+    if (!(s->config_reg & (1U << 31))) {
         return 0xffffffff;
+    }
     val = pci_data_read(s->bus, s->config_reg | (addr & 3), len);
     PCI_DPRINTF("read addr " TARGET_FMT_plx " len %d val %x\n",
                 addr, len, val);
-- 
1.7.10.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]