[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 12/23] hw/pci/pci_host.c: Avoid shifting left into si
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 12/23] hw/pci/pci_host.c: Avoid shifting left into sign bit |
Date: |
Thu, 27 Mar 2014 19:28:17 +0400 |
From: Peter Maydell <address@hidden>
Add U suffix to avoid undefined behaviour.
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/pci/pci_host.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c
index 77c7d1f..3e26f92 100644
--- a/hw/pci/pci_host.c
+++ b/hw/pci/pci_host.c
@@ -142,8 +142,9 @@ static uint64_t pci_host_data_read(void *opaque,
{
PCIHostState *s = opaque;
uint32_t val;
- if (!(s->config_reg & (1 << 31)))
+ if (!(s->config_reg & (1U << 31))) {
return 0xffffffff;
+ }
val = pci_data_read(s->bus, s->config_reg | (addr & 3), len);
PCI_DPRINTF("read addr " TARGET_FMT_plx " len %d val %x\n",
addr, len, val);
--
1.7.10.4
- [Qemu-devel] [PULL for-2.0 00/23] Trivial patches for 2014-03-27, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 07/23] doc: update sun4m documentation, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 06/23] fix return check for KVM_GET_DIRTY_LOG ioctl, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 05/23] target-i386: Add missing 'static' and 'const' attributes, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 23/23] linux-user: remove duplicate statement, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 12/23] hw/pci/pci_host.c: Avoid shifting left into sign bit,
Michael Tokarev <=
- [Qemu-devel] [PULL 20/23] hw/intc/xilinx_intc: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 13/23] hw/i386/acpi_build.c: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 21/23] hw/pci-host/apb.c: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 10/23] target-i386: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 14/23] target-mips: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 22/23] hw/timer/grlib_gptimer: remove unnecessary assignment, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 01/23] target-s390x: Add missing 'static' and 'const' attributes, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 17/23] hw/ppc: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 16/23] hw/intc/openpic: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 15/23] hw/usb/hcd-ohci.c: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27