[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 15/23] hw/usb/hcd-ohci.c: Avoid shifting left into si
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 15/23] hw/usb/hcd-ohci.c: Avoid shifting left into sign bit |
Date: |
Thu, 27 Mar 2014 19:28:20 +0400 |
From: Peter Maydell <address@hidden>
Add U suffix to avoid undefined behaviour. This is only
strictly necessary for the 1<<31 cases, but we add it for the
other constants in these groups for consistency.
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/usb/hcd-ohci.c | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 3d35058..93f186f 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -234,15 +234,15 @@ struct ohci_iso_td {
#define OHCI_STATUS_OCR (1<<3)
#define OHCI_STATUS_SOC ((1<<6)|(1<<7))
-#define OHCI_INTR_SO (1<<0) /* Scheduling overrun */
-#define OHCI_INTR_WD (1<<1) /* HcDoneHead writeback */
-#define OHCI_INTR_SF (1<<2) /* Start of frame */
-#define OHCI_INTR_RD (1<<3) /* Resume detect */
-#define OHCI_INTR_UE (1<<4) /* Unrecoverable error */
-#define OHCI_INTR_FNO (1<<5) /* Frame number overflow */
-#define OHCI_INTR_RHSC (1<<6) /* Root hub status change */
-#define OHCI_INTR_OC (1<<30) /* Ownership change */
-#define OHCI_INTR_MIE (1<<31) /* Master Interrupt Enable */
+#define OHCI_INTR_SO (1U<<0) /* Scheduling overrun */
+#define OHCI_INTR_WD (1U<<1) /* HcDoneHead writeback */
+#define OHCI_INTR_SF (1U<<2) /* Start of frame */
+#define OHCI_INTR_RD (1U<<3) /* Resume detect */
+#define OHCI_INTR_UE (1U<<4) /* Unrecoverable error */
+#define OHCI_INTR_FNO (1U<<5) /* Frame number overflow */
+#define OHCI_INTR_RHSC (1U<<6) /* Root hub status change */
+#define OHCI_INTR_OC (1U<<30) /* Ownership change */
+#define OHCI_INTR_MIE (1U<<31) /* Master Interrupt Enable */
#define OHCI_HCCA_SIZE 0x100
#define OHCI_HCCA_MASK 0xffffff00
@@ -253,7 +253,7 @@ struct ohci_iso_td {
#define OHCI_FMI_FSMPS 0xffff0000
#define OHCI_FMI_FIT 0x80000000
-#define OHCI_FR_RT (1<<31)
+#define OHCI_FR_RT (1U<<31)
#define OHCI_LS_THRESH 0x628
@@ -265,12 +265,12 @@ struct ohci_iso_td {
#define OHCI_RHA_NOCP (1<<12)
#define OHCI_RHA_POTPGT_MASK 0xff000000
-#define OHCI_RHS_LPS (1<<0)
-#define OHCI_RHS_OCI (1<<1)
-#define OHCI_RHS_DRWE (1<<15)
-#define OHCI_RHS_LPSC (1<<16)
-#define OHCI_RHS_OCIC (1<<17)
-#define OHCI_RHS_CRWE (1<<31)
+#define OHCI_RHS_LPS (1U<<0)
+#define OHCI_RHS_OCI (1U<<1)
+#define OHCI_RHS_DRWE (1U<<15)
+#define OHCI_RHS_LPSC (1U<<16)
+#define OHCI_RHS_OCIC (1U<<17)
+#define OHCI_RHS_CRWE (1U<<31)
#define OHCI_PORT_CCS (1<<0)
#define OHCI_PORT_PES (1<<1)
--
1.7.10.4
- [Qemu-devel] [PULL 12/23] hw/pci/pci_host.c: Avoid shifting left into sign bit, (continued)
- [Qemu-devel] [PULL 12/23] hw/pci/pci_host.c: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 20/23] hw/intc/xilinx_intc: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 13/23] hw/i386/acpi_build.c: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 21/23] hw/pci-host/apb.c: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 10/23] target-i386: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 14/23] target-mips: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 22/23] hw/timer/grlib_gptimer: remove unnecessary assignment, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 01/23] target-s390x: Add missing 'static' and 'const' attributes, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 17/23] hw/ppc: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 16/23] hw/intc/openpic: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 15/23] hw/usb/hcd-ohci.c: Avoid shifting left into sign bit,
Michael Tokarev <=
- [Qemu-devel] [PULL 09/23] CODING_STYLE: Section about mixed declarations, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 18/23] tests/libqos/pci-pc: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 02/23] target-arm: Add missing 'static' attribute, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 08/23] doc: update default PowerPC framebuffer settings, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 04/23] util: Add 'static' attribute to function implementation, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 19/23] hw/intc/slavio_intctl: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 11/23] hw/intc/apic.c: Use uint32_t for mask word in foreach_apic, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 03/23] hw/ide: Add missing 'static' attributes, Michael Tokarev, 2014/03/27
- Re: [Qemu-devel] [PULL for-2.0 00/23] Trivial patches for 2014-03-27, Peter Maydell, 2014/03/27