[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 18/23] tests/libqos/pci-pc: Avoid shifting left into
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 18/23] tests/libqos/pci-pc: Avoid shifting left into sign bit |
Date: |
Thu, 27 Mar 2014 19:28:23 +0400 |
From: Peter Maydell <address@hidden>
Add U suffix when doing "1 << 31" to avoid undefined behaviour.
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
tests/libqos/pci-pc.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/libqos/pci-pc.c b/tests/libqos/pci-pc.c
index 3bde8ab..bf741a4 100644
--- a/tests/libqos/pci-pc.c
+++ b/tests/libqos/pci-pc.c
@@ -110,37 +110,37 @@ static void qpci_pc_io_writel(QPCIBus *bus, void *addr,
uint32_t value)
static uint8_t qpci_pc_config_readb(QPCIBus *bus, int devfn, uint8_t offset)
{
- outl(0xcf8, (1 << 31) | (devfn << 8) | offset);
+ outl(0xcf8, (1U << 31) | (devfn << 8) | offset);
return inb(0xcfc);
}
static uint16_t qpci_pc_config_readw(QPCIBus *bus, int devfn, uint8_t offset)
{
- outl(0xcf8, (1 << 31) | (devfn << 8) | offset);
+ outl(0xcf8, (1U << 31) | (devfn << 8) | offset);
return inw(0xcfc);
}
static uint32_t qpci_pc_config_readl(QPCIBus *bus, int devfn, uint8_t offset)
{
- outl(0xcf8, (1 << 31) | (devfn << 8) | offset);
+ outl(0xcf8, (1U << 31) | (devfn << 8) | offset);
return inl(0xcfc);
}
static void qpci_pc_config_writeb(QPCIBus *bus, int devfn, uint8_t offset,
uint8_t value)
{
- outl(0xcf8, (1 << 31) | (devfn << 8) | offset);
+ outl(0xcf8, (1U << 31) | (devfn << 8) | offset);
outb(0xcfc, value);
}
static void qpci_pc_config_writew(QPCIBus *bus, int devfn, uint8_t offset,
uint16_t value)
{
- outl(0xcf8, (1 << 31) | (devfn << 8) | offset);
+ outl(0xcf8, (1U << 31) | (devfn << 8) | offset);
outw(0xcfc, value);
}
static void qpci_pc_config_writel(QPCIBus *bus, int devfn, uint8_t offset,
uint32_t value)
{
- outl(0xcf8, (1 << 31) | (devfn << 8) | offset);
+ outl(0xcf8, (1U << 31) | (devfn << 8) | offset);
outl(0xcfc, value);
}
--
1.7.10.4
- [Qemu-devel] [PULL 13/23] hw/i386/acpi_build.c: Avoid shifting left into sign bit, (continued)
- [Qemu-devel] [PULL 13/23] hw/i386/acpi_build.c: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 21/23] hw/pci-host/apb.c: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 10/23] target-i386: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 14/23] target-mips: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 22/23] hw/timer/grlib_gptimer: remove unnecessary assignment, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 01/23] target-s390x: Add missing 'static' and 'const' attributes, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 17/23] hw/ppc: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 16/23] hw/intc/openpic: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 15/23] hw/usb/hcd-ohci.c: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 09/23] CODING_STYLE: Section about mixed declarations, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 18/23] tests/libqos/pci-pc: Avoid shifting left into sign bit,
Michael Tokarev <=
- [Qemu-devel] [PULL 02/23] target-arm: Add missing 'static' attribute, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 08/23] doc: update default PowerPC framebuffer settings, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 04/23] util: Add 'static' attribute to function implementation, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 19/23] hw/intc/slavio_intctl: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 11/23] hw/intc/apic.c: Use uint32_t for mask word in foreach_apic, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 03/23] hw/ide: Add missing 'static' attributes, Michael Tokarev, 2014/03/27
- Re: [Qemu-devel] [PULL for-2.0 00/23] Trivial patches for 2014-03-27, Peter Maydell, 2014/03/27