qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 2/4] qemu-log: support simple pid substituti


From: Leandro Dorileo
Subject: Re: [Qemu-devel] [RFC PATCH 2/4] qemu-log: support simple pid substitution in logfile
Date: Fri, 28 Mar 2014 09:19:00 -0300
User-agent: Mutt/1.5.23 (2014-03-12)

On Thu, Mar 27, 2014 at 09:59:21AM +0000, Alex Bennée wrote:
> 
> Leandro Dorileo <address@hidden> writes:
> 
> > On Wed, Mar 26, 2014 at 02:37:12PM +0000, address@hidden wrote:
> >> From: Alex Bennée <address@hidden>
> >> 
> >> When debugging stuff that occurs over several forks it would be useful
> >> not to keep overwriting the one logfile you've set-up. This allows a
> >> simple %d to be included once in the logfile parameter which is
> >> substituted with getpid().
> <snip>
> >
> > Looks good to me.
> 
> Is that a Reviewed-by? If you include a Reviewed-by tag it makes it
> easier to copy and paste into the commit for the next iteration.

Sure, you can add

Reviewed-by: Leandro Dorileo <address@hidden>

-- 
Leandro Dorileo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]