Re: [Qemu-devel] [RFC 0/3] tcg: Avoid undefined behaviour on unaligned stores

[Richard Henderson]

On 03/28/2014 11:18 AM, Peter Maydell wrote:
> On 28 March 2014 18:06, Richard Henderson <address@hidden> wrote:
>> On 03/28/2014 08:29 AM, Peter Maydell wrote:
>>> Peter Maydell (3):
>>>   exec-all.h: Use stl_p to avoid undefined behaviour patching x86 jumps
>>>   tcg: Avoid stores to unaligned addresses
>>>   tcg: Avoid undefined behaviour patching code at unaligned addresses
>>
>> Reviewed-by: Richard Henderson <address@hidden>
> 
> I was expecting more argument :-)
> 
> I'll do a respin with separate tcg_out*_unaligned and tcg_out*,
> and update all the backends.

Please don't.  I'd rather make different changes there, making s->code_ptr be
more appropriate to the elemental type of the native insn.

Since x86 wouldn't change its elemental type, I think your change is the best
of the possible solutions there.


r~