qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.0 46/47] parallels: Fix catalog size integ


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH for-2.0 46/47] parallels: Fix catalog size integer overflow (CVE-2014-0143)
Date: Sat, 29 Mar 2014 00:45:56 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

On 26.03.2014 13:06, Stefan Hajnoczi wrote:
From: Kevin Wolf <address@hidden>

The first test case would cause a huge memory allocation, leading to a
qemu abort; the second one to a too small malloc() for the catalog
(smaller than s->catalog_size), which causes a read-only out-of-bounds
array access and on big endian hosts an endianess conversion for an
undefined memory area.

The sample image used here is not an original Parallels image. It was
created using an hexeditor on the basis of the struct that qemu uses.
Good enough for trying to crash the driver, but not for ensuring
compatibility.

Signed-off-by: Kevin Wolf <address@hidden>
---
  block/parallels.c                                  |   7 ++-
  tests/qemu-iotests/076                             |  69 +++++++++++++++++++++
  tests/qemu-iotests/076.out                         |  14 +++++
  tests/qemu-iotests/common                          |   7 +++
  tests/qemu-iotests/group                           |   1 +
  .../qemu-iotests/sample_images/fake.parallels.bz2  | Bin 0 -> 141 bytes
  6 files changed, 97 insertions(+), 1 deletion(-)
  create mode 100755 tests/qemu-iotests/076
  create mode 100644 tests/qemu-iotests/076.out
  create mode 100644 tests/qemu-iotests/sample_images/fake.parallels.bz2

Reviewed-by: Max Reitz <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]