[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 08/17] monitor: Add netdev_add type argument comp
From: |
Hani Benhabiles |
Subject: |
[Qemu-devel] [PATCH v2 08/17] monitor: Add netdev_add type argument completion. |
Date: |
Sun, 30 Mar 2014 11:58:30 +0100 |
Also update the command's documentation.
Signed-off-by: Hani Benhabiles <address@hidden>
---
hmp-commands.hx | 3 ++-
hmp.h | 1 +
monitor.c | 18 ++++++++++++++++++
3 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index fbd303a..b009561 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1226,9 +1226,10 @@ ETEXI
{
.name = "netdev_add",
.args_type = "netdev:O",
- .params =
"[user|tap|socket|hubport|netmap],id=str[,prop=value][,...]",
+ .params =
"[user|tap|socket|vde|bridge|hubport|netmap],id=str[,prop=value][,...]",
.help = "add host network device",
.mhandler.cmd = hmp_netdev_add,
+ .command_completion = netdev_add_completion,
},
STEXI
diff --git a/hmp.h b/hmp.h
index 33a883d..9dab1a3 100644
--- a/hmp.h
+++ b/hmp.h
@@ -101,5 +101,6 @@ void chardev_remove_completion(ReadLineState *rs, int
nb_args, const char *str);
void chardev_add_completion(ReadLineState *rs, int nb_args, const char *str);
void cpu_completion(ReadLineState *rs, int nb_args, const char *str);
void set_link_completion(ReadLineState *rs, int nb_args, const char *str);
+void netdev_add_completion(ReadLineState *rs, int nb_args, const char *str);
#endif
diff --git a/monitor.c b/monitor.c
index 009f269..5293370 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4312,6 +4312,24 @@ void chardev_add_completion(ReadLineState *rs, int
nb_args, const char *str)
qapi_free_ChardevBackendInfoList(start);
}
+void netdev_add_completion(ReadLineState *rs, int nb_args, const char *str)
+{
+ size_t len;
+
+ if (nb_args != 2) {
+ return;
+ }
+ len = strlen(str);
+ readline_set_completion_index(rs, len);
+ add_completion_option(rs, str, "user");
+ add_completion_option(rs, str, "tap");
+ add_completion_option(rs, str, "socket");
+ add_completion_option(rs, str, "vde");
+ add_completion_option(rs, str, "bridge");
+ add_completion_option(rs, str, "hubport");
+ add_completion_option(rs, str, "netmap");
+}
+
void device_add_completion(ReadLineState *rs, int nb_args, const char *str)
{
GSList *list, *elt;
--
1.8.3.2
- [Qemu-devel] [PATCH v2 00/17] monitor: Completion support for various commands, Hani Benhabiles, 2014/03/30
- [Qemu-devel] [PATCH v2 01/17] monitor: Fix drive_del id argument type completion., Hani Benhabiles, 2014/03/30
- [Qemu-devel] [PATCH v2 02/17] monitor: Add command_completion callback to mon_cmd_t., Hani Benhabiles, 2014/03/30
- [Qemu-devel] [PATCH v2 03/17] monitor: Add device_add and device_del completion., Hani Benhabiles, 2014/03/30
- [Qemu-devel] [PATCH v2 04/17] monitor: Add chardev-remove id argument completion., Hani Benhabiles, 2014/03/30
- [Qemu-devel] [PATCH v2 05/17] monitor: Add chardev-add backend argument completion., Hani Benhabiles, 2014/03/30
- [Qemu-devel] [PATCH v2 06/17] monitor: Add cpu index argument completion., Hani Benhabiles, 2014/03/30
- [Qemu-devel] [PATCH v2 07/17] monitor: Add set_link arguments completion., Hani Benhabiles, 2014/03/30
- [Qemu-devel] [PATCH v2 08/17] monitor: Add netdev_add type argument completion.,
Hani Benhabiles <=
- [Qemu-devel] [PATCH v2 09/17] monitor: Add netdev_del id argument completion., Hani Benhabiles, 2014/03/30
- [Qemu-devel] [PATCH v2 10/17] monitor: Add ringbuf_write and ringbuf_read argument completion., Hani Benhabiles, 2014/03/30
- [Qemu-devel] [PATCH v2 11/17] monitor: Add watchdog_action argument completion., Hani Benhabiles, 2014/03/30
- [Qemu-devel] [PATCH v2 12/17] monitor: Add migrate_set_capability completion., Hani Benhabiles, 2014/03/30
- [Qemu-devel] [PATCH v2 13/17] monitor: Add host_net_add device argument completion., Hani Benhabiles, 2014/03/30
- [Qemu-devel] [PATCH v2 14/17] readline: Make completion strings always unique., Hani Benhabiles, 2014/03/30
- [Qemu-devel] [PATCH v2 15/17] monitor: Add host_net_remove arguments completion., Hani Benhabiles, 2014/03/30
- [Qemu-devel] [PATCH v2 16/17] monitor: Add mouse_set index argument completion., Hani Benhabiles, 2014/03/30
- [Qemu-devel] [PATCH v2 17/17] monitor: Add delvm and loadvm argument completion., Hani Benhabiles, 2014/03/30