Re: [Qemu-devel] [PATCH] tests/Makefile: Run qom-test for every architecture

[Peter Maydell]

On 31 March 2014 09:10, Andreas Färber <address@hidden> wrote:
> Am 23.01.2014 17:22, schrieb Peter Maydell:
>> +# Get the list of all supported sysemu targets
>> +SYSEMU_TARGET_LIST := $(subst -softmmu.mak,,$(notdir \
>> +   $(wildcard $(SRC_PATH)/default-configs/*-softmmu.mak)))
>> +
>>  check-unit-y = tests/check-qdict$(EXESUF)
>>  gcov-files-check-qdict-y = qobject/qdict.c
>>  check-unit-y += tests/check-qfloat$(EXESUF)
>> @@ -71,7 +75,6 @@ check-qtest-i386-y += tests/acpi-test$(EXESUF)
>>  check-qtest-i386-y += tests/rtc-test$(EXESUF)
>>  check-qtest-i386-y += tests/i440fx-test$(EXESUF)
>>  check-qtest-i386-y += tests/fw_cfg-test$(EXESUF)
>> -check-qtest-i386-y += tests/qom-test$(EXESUF)
>>  check-qtest-i386-y += tests/blockdev-test$(EXESUF)
>>  check-qtest-i386-y += tests/qdev-monitor-test$(EXESUF)
>>  check-qtest-x86_64-y = $(check-qtest-i386-y)
>
> qom-test gets executed twice for x86_64 now.

It doesn't for me:

TESTER check-qtest-sparc
GTESTER check-qtest-sparc64
GTESTER check-qtest-unicore32
GTESTER check-qtest-x86_64
blkdebug: Suspended request 'A'
blkdebug: Resuming request 'A'
[vmxnet3][WR][vmxnet3_peer_has_vnet_hdr]: Peer has no virtio
extension. Task offloads will be emulated.
GTESTER check-qtest-xtensa
GTESTER check-qtest-xtensaeb

> Without having debugged this further yet, my guess is this last line is
> causing qom-test to get added twice to check-qtest-x86_64-y, once
> inherited from check-qtest-i386-y and then newly added like for any
> other target.

When I was writing the patch I did think about whether this was
going to be a problem, but I realised that it would not, because the
check-qtest-*-y we're building up here are not lists of commands
to run, but lists of Makefile targets. Make will automatically only
run the target once even if it happens to be specified twice on the
RHS of a rule.

thanks
-- PMM