[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] input: mouse_set should check input device type
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] input: mouse_set should check input device type. |
|
Date: |
Mon, 31 Mar 2014 14:45:49 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Gerd Hoffmann <address@hidden> writes:
>> + if (!(s->handler->mask & (INPUT_EVENT_MASK_REL |
>> + INPUT_EVENT_MASK_ABS))) {
>> + monitor_printf(mon, "Input device '%s' is not a mouse",
>> + s->handler->name);
>
> That should be error_report (I think, Markus?).
Yes, please. Same for the "Mouse at given index not found\n" message
further down. Note that error_report() does *not* want \n.
>
> Otherwise the patch is fine.
>
> cheers,
> Gerd