qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 2/8] virtio: allow byte swapping for vring an


From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH v6 2/8] virtio: allow byte swapping for vring and config access
Date: Mon, 31 Mar 2014 18:24:08 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130910 Thunderbird/17.0.9

On 03/28/2014 11:57 AM, Greg Kurz wrote:
From: Rusty Russell <address@hidden>

This is based on a simpler patch by Anthony Liguouri, which only handled
the vring accesses.  We also need some drivers to access these helpers,
eg. for data which contains headers.

Signed-off-by: Rusty Russell <address@hidden>
[ ldq_phys() API change,
   use per-device needs_byteswap flag,
   Greg Kurz <address@hidden> ]
Signed-off-by: Greg Kurz <address@hidden>
---
  hw/virtio/virtio.c |   93 ++++++++++++++++++++++++++++++----------------------
  1 file changed, 53 insertions(+), 40 deletions(-)

diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 24b565f..1877b46 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -102,53 +102,57 @@ static void virtqueue_init(VirtQueue *vq)
                                   vq->vring.align);
  }
-static inline uint64_t vring_desc_addr(hwaddr desc_pa, int i)
+static inline uint64_t vring_desc_addr(hwaddr desc_pa, int i,
+                                       struct VirtIODevice *vdev)

The logical ordering for helper is usually to have the device as the first parameter (it's basically the self object). Could you please order it accordingly?


Alex




reply via email to

[Prev in Thread] Current Thread [Next in Thread]