[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-2.0 4/7] tmp105: read temperature in milli-celsi
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH for-2.0 4/7] tmp105: read temperature in milli-celsius |
Date: |
Mon, 31 Mar 2014 18:26:32 +0200 |
Right now, the temperature property must be written in milli-celsius, but it
reads back the value in 8.8 fixed point. Fix this by letting the property
read back the original value (possibly rounded). Also simplify the code that
does the conversion.
Before:
(QEMU) qom-set path=/machine/peripheral/sensor property=temperature
value=20000
{u'return': {}}
(QEMU) qom-get path=sensor property=temperature
{u'return': 5120}
After:
(QEMU) qom-set path=/machine/peripheral/sensor property=temperature
value=20000
{u'return': {}}
(QEMU) qom-get path=sensor property=temperature
{u'return': 20000}
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/misc/tmp105.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/misc/tmp105.c b/hw/misc/tmp105.c
index caec4a5..244c1ef 100644
--- a/hw/misc/tmp105.c
+++ b/hw/misc/tmp105.c
@@ -56,12 +56,14 @@ static void tmp105_get_temperature(Object *obj, Visitor *v,
void *opaque,
const char *name, Error **errp)
{
TMP105State *s = TMP105(obj);
- int64_t value = s->temperature;
+ int64_t value = s->temperature * 1000 / 256;
visit_type_int(v, &value, name, errp);
}
-/* Units are 0.001 centigrades relative to 0 C. */
+/* Units are 0.001 centigrades relative to 0 C. s->temperature is 8.8
+ * fixed point, so units are 1/256 centigrades. A simple ratio will do.
+ */
static void tmp105_set_temperature(Object *obj, Visitor *v, void *opaque,
const char *name, Error **errp)
{
@@ -80,7 +82,7 @@ static void tmp105_set_temperature(Object *obj, Visitor *v,
void *opaque,
return;
}
- s->temperature = ((int16_t) (temp * 0x800 / 128000)) << 4;
+ s->temperature = (int16_t) (temp * 256 / 1000);
tmp105_alarm_update(s);
}
--
1.9.0
- [Qemu-devel] [PATCH for-2.0 0/7] SMBus and tmp105 fixes, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 1/7] smbus: allow returning an error from reads, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 2/7] smbus: return -1 if nothing found at the given address, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 3/7] pm_smbus: correctly report unclaimed cycles, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 4/7] tmp105: read temperature in milli-celsius,
Paolo Bonzini <=
- [Qemu-devel] [PATCH for-2.0 5/7] tmp105-test: wrap simple building blocks for testing, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 6/7] tmp105-test: add a second sensor and test that one, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 7/7] tmp105-test: test QOM property and precision, Paolo Bonzini, 2014/03/31
- Re: [Qemu-devel] [PATCH for-2.0 0/7] SMBus and tmp105 fixes, Andreas Färber, 2014/03/31