Re: [Qemu-devel] [PATCH v6 6/8] virtio-scsi: use virtio wrappers to access headers

[Alexander Graf]

On 03/28/2014 11:57 AM, Greg Kurz wrote:
> From: Rusty Russell <address@hidden>
>
> Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p.
>
> Signed-off-by: Rusty Russell <address@hidden>
> Reviewed-by: Anthony Liguori <address@hidden>
> [ use per-device needs_byteswap flag,
>    fix missing tswap32 in virtio_scsi_push_event(),
>    Greg Kurz <address@hidden> ]
> Signed-off-by: Greg Kurz <address@hidden>
> ---
>   hw/scsi/virtio-scsi.c |   38 ++++++++++++++++++++------------------
>   1 file changed, 20 insertions(+), 18 deletions(-)
>
> diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
> index b0d7517..20d326e 100644
> --- a/hw/scsi/virtio-scsi.c
> +++ b/hw/scsi/virtio-scsi.c
> @@ -18,6 +18,7 @@
>   #include <hw/scsi/scsi.h>
>   #include <block/scsi.h>
>   #include <hw/virtio/virtio-bus.h>
> +#include "hw/virtio/virtio-access.h"

Just a small nit, but I spot some inconsitency in < and " usage here :)


Alex