Re: [Qemu-devel] [PATCH for-2.0] pci: Fix clearing IRQs on reset

[Peter Maydell]

On 31 March 2014 19:53, Michael S. Tsirkin <address@hidden> wrote:
> On Mon, Mar 31, 2014 at 02:31:44PM -0400, Cole Robinson wrote:
>> irq_state is cleared before calling pci_device_deassert_intx, but the
>> latter misbehaves if the former isn't accurate. In this case, any raised
>> IRQs are not cleared, which hits an assertion in pcibus_reset:
>>
>> qemu-system-x86_64: hw/pci/pci.c:250: pcibus_reset: Assertion
>> `bus->irq_count[i] == 0' failed.
>>
>> pci_device_deassert_intx should clear irq_state anyways, so add
>> an assert.
>>
>> This fixes migration with usb2 + usb-tablet.
>>
>> Signed-off-by: Cole Robinson <address@hidden>
>
>
> Reviewed-by: Michael S. Tsirkin <address@hidden>
>
> Peter, could you pick this up for RC3 if not too late?

Applied to master, thanks.

thanks
-- PMM