[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.0 2/7] smbus: return -1 if nothing found a
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH for-2.0 2/7] smbus: return -1 if nothing found at the given address |
Date: |
Mon, 31 Mar 2014 23:29:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 31.03.2014 18:26, schrieb Paolo Bonzini:
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/i2c/smbus.c | 62
> +++++++++++++++++++++++++++++++++++---------------
> include/hw/i2c/smbus.h | 12 +++++-----
> 2 files changed, 50 insertions(+), 24 deletions(-)
>
> diff --git a/hw/i2c/smbus.c b/hw/i2c/smbus.c
> index 190f08e..6e27ae8 100644
> --- a/hw/i2c/smbus.c
> +++ b/hw/i2c/smbus.c
> @@ -208,34 +208,44 @@ static int smbus_device_init(I2CSlave *i2c)
> }
>
> /* Master device commands. */
> -void smbus_quick_command(I2CBus *bus, uint8_t addr, int read)
> +int smbus_quick_command(I2CBus *bus, uint8_t addr, int read)
> {
> - i2c_start_transfer(bus, addr, read);
> + if (i2c_start_transfer(bus, addr, read)) {
For anyone else who wondered about this condition: i2c_start_transfer()
returns 1 if slave device is not found and 0 on success, so no normal
return codes interfering here.
> + return -1;
> + }
> i2c_end_transfer(bus);
> + return 0;
> }
[snip]
Reviewed-by: Andreas Färber <address@hidden>
Might have mentioned also doing some adjacent Coding Style cleanups.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH for-2.0 0/7] SMBus and tmp105 fixes, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 1/7] smbus: allow returning an error from reads, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 2/7] smbus: return -1 if nothing found at the given address, Paolo Bonzini, 2014/03/31
- Re: [Qemu-devel] [PATCH for-2.0 2/7] smbus: return -1 if nothing found at the given address,
Andreas Färber <=
- [Qemu-devel] [PATCH for-2.0 3/7] pm_smbus: correctly report unclaimed cycles, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 4/7] tmp105: read temperature in milli-celsius, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 5/7] tmp105-test: wrap simple building blocks for testing, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 6/7] tmp105-test: add a second sensor and test that one, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 7/7] tmp105-test: test QOM property and precision, Paolo Bonzini, 2014/03/31
- Re: [Qemu-devel] [PATCH for-2.0 0/7] SMBus and tmp105 fixes, Andreas Färber, 2014/03/31