qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH for-2.0 v1 1/1] timer: cadence_ttc: Fix match regist


From: Peter Crosthwaite
Subject: [Qemu-devel] [PATCH for-2.0 v1 1/1] timer: cadence_ttc: Fix match register write logic
Date: Mon, 31 Mar 2014 21:31:09 -0700

This switch logic should not fall through. Fix.

Signed-off-by: Peter Crosthwaite <address@hidden>
---
Spotted by Coverity (via PMM)

 hw/timer/cadence_ttc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/timer/cadence_ttc.c b/hw/timer/cadence_ttc.c
index a279bce..28cb328 100644
--- a/hw/timer/cadence_ttc.c
+++ b/hw/timer/cadence_ttc.c
@@ -346,11 +346,13 @@ static void cadence_ttc_write(void *opaque, hwaddr offset,
     case 0x34:
     case 0x38:
         s->reg_match[0] = value & 0xffff;
+        break;
 
     case 0x3c: /* match register */
     case 0x40:
     case 0x44:
         s->reg_match[1] = value & 0xffff;
+        break;
 
     case 0x48: /* match register */
     case 0x4c:
-- 
1.9.1.1.gbb9f595




reply via email to

[Prev in Thread] Current Thread [Next in Thread]