[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/8] tcg: tidy the type of code_ptr
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 0/8] tcg: tidy the type of code_ptr |
Date: |
Tue, 01 Apr 2014 13:05:22 +0100 |
User-agent: |
mu4e 0.9.9.6pre2; emacs 24.3.50.5 |
Richard Henderson <address@hidden> writes:
> On 03/29/2014 01:26 PM, Peter Maydell wrote:
>> It seems like it might be worth abstracting out "give me the byte
>> difference between these two code pointers" rather than having
>> inline (uintptr_t)codeptr1 - (uintptr_t)codeptr2, but I dunno.
>
> Yeah, I dithered about that. I couldn't come up with a good name that
> adequately described what I wanted that was really any shorter than just
> having
> the casts.
>
>> Is there a better name than 'tcg_itype' ? Putting 'type' in the
>> name of a type is a bit redundant, and suggests it contains
>> a type rather than an insn.
>
> I'm open to suggestions there as well. On x86 and ia64, it won't hold an
> entire insn, so "tcg_insn" seemed inappropriate.
<snip>
tcg_insn_stream?
--
Alex Bennée
- Re: [Qemu-devel] [PATCH 0/8] tcg: tidy the type of code_ptr,
Alex Bennée <=