Re: [Qemu-devel] [PATCH trival] vl.c: clean up code

[Chen Gang]

On 04/01/2014 08:36 PM, Alex Bennée wrote:
> 
> Chen Gang <address@hidden> writes:
> 
>> Hello Maintainers:
>>
>> In main switch of main(), it contents several styles for "{...}" code block.
>>
>> If it is necessary to use unique style within a function, please let me
>> know, I will/should clean up it. And also better to tell me which style
>> we need choose -- for me, I don't know which style is the best to
>> Qemu.
> 
> The correct block style is described in CODING_STYLE Section 4. However
> chunks of the code base violate the style guidelines and should be
> cleaned up as other fixes are made.
> 

In CODING_STYLE Section 4, has no demo for "{...}" within switch, I
guess your meaning is "the demo below is the correct block style for Qemu":

        switch(...) {
        case 'x': {
                char a;
                ...
                break;
        }
        case 'y':
                ...
                break;
        default:
                break;
        }

If it is OK, suggest to complete the CODING_STYLE Section 4 with one
'switch' demo.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed