Re: [Qemu-devel] [PATCH 2/5] hw/net/stellaris_enet: Correct handling of packet padding

[Dr. David Alan Gilbert]

* Peter Maydell (address@hidden) wrote:
> The PADEN bit in the transmit control register enables padding of short
> data packets out to the required minimum length. However a typo here
> meant we were adjusting tx_fifo_len rather than tx_frame_len, so the
> padding didn't actually happen. Fix this bug.
> 
> Signed-off-by: Peter Maydell <address@hidden>

Reviewed-by: Dr. David Alan Gilbert <address@hidden>

> ---
>  hw/net/stellaris_enet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c
> index bd844cd..d0da819 100644
> --- a/hw/net/stellaris_enet.c
> +++ b/hw/net/stellaris_enet.c
> @@ -265,7 +265,7 @@ static void stellaris_enet_write(void *opaque, hwaddr 
> offset,
>                      s->tx_frame_len -= 4;
>                  if ((s->tctl & SE_TCTL_PADEN) && s->tx_frame_len < 60) {
>                      memset(&s->tx_fifo[s->tx_frame_len], 0, 60 - 
> s->tx_frame_len);
> -                    s->tx_fifo_len = 60;
> +                    s->tx_frame_len = 60;
>                  }
>                  qemu_send_packet(qemu_get_queue(s->nic), s->tx_fifo,
>                                   s->tx_frame_len);
> -- 
> 1.9.0
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK