[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.0 2/2] prep: remove CPU reset entry point
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.0 2/2] prep: remove CPU reset entry point hack related to OpenHack'Ware |
|
Date: |
Wed, 02 Apr 2014 15:47:24 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 02.04.2014 14:48, schrieb Paolo Bonzini:
> Il 01/04/2014 23:19, Hervé Poussineau ha scritto:
>> Signed-off-by: Hervé Poussineau <address@hidden>
>>
>> ---
>> hw/ppc/prep.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
>> index 035b5b2..dfe4a5c 100644
>> --- a/hw/ppc/prep.c
>> +++ b/hw/ppc/prep.c
>> @@ -346,9 +346,6 @@ static void ppc_prep_reset(void *opaque)
>> PowerPCCPU *cpu = opaque;
>>
>> cpu_reset(CPU(cpu));
>> -
>> - /* Reset address */
>> - cpu->env.nip = 0xfffffffc;
>> }
>>
>> static const MemoryRegionPortio prep_portio_list[] = {
>>
>
> Is ppc_prep_reset needed at all now?
I believe so, CPU reset is historically handled by the machines rather
than by CPUs themselves. (also Alpha is an oddball in not handling nor
implementing reset - some WIP on qom-cpu-alpha)
Regards,
Andreas