qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instea


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instead of motion-notify-event
Date: Wed, 02 Apr 2014 17:17:54 +0200

On Mi, 2014-04-02 at 14:32 +0200, Takashi Iwai wrote:
> +static gboolean gd_event(GtkWidget *widget, GdkEvent *event, void
> *opaque)
> +{
> +    if (event->type == GDK_MOTION_NOTIFY)
> +        return gd_motion_event(widget, &event->motion, opaque);
> +    return FALSE;
> +}

Fails checkpatch:

WARNING: braces {} are necessary for all arms of this statement
#12: FILE: ui/gtk.c:771:
+    if (event->type == GDK_MOTION_NOTIFY)
[...]

total: 0 errors, 1 warnings, 23 lines checked

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]