[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC for-2.0] bswap: Fix build on FreeBSD 10.0
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [RFC for-2.0] bswap: Fix build on FreeBSD 10.0 |
|
Date: |
Wed, 02 Apr 2014 11:52:34 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/02/2014 07:06 AM, Andreas Färber wrote:
> FreeBSD 10.0-RELEASE has bswap16() etc. macros defined in sys/endian.h,
> which leads to a conflict with our static inline definitions.
>
> Force using the system version of the macros.
>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
> On 9.0-RELEASE I did not have this issue, so unsure if some version check
> is needed or some more generic configure check?
Looks plausible, but I have no bsd specific experience.
I'd say if it works for both 9.0 and 10.0, let it go in as is.
r~