[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mod
From: |
Cole Robinson |
Subject: |
Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode |
Date: |
Wed, 02 Apr 2014 16:18:15 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/02/2014 11:25 AM, Takashi Iwai wrote:
> At Wed, 02 Apr 2014 17:19:51 +0200,
> Gerd Hoffmann wrote:
>>
>> On Mi, 2014-04-02 at 11:07 -0400, Cole Robinson wrote:
>>> + if (button->button == 1 &&
>>> + button->type == GDK_BUTTON_PRESS &&
>>> + !gd_is_grab_active(s) &&
>>> + !qemu_input_is_absolute()) {
>>> +
>>> gtk_check_menu_item_set_active(GTK_CHECK_MENU_ITEM(s->grab_item),
>>> + TRUE);
>>> + return TRUE;
>>> + }
>>
>> Looks sane on a quick glance (as replacement for patch #4 of Takashi's
>> patch series). Didn't test yet.
>
> Unfortunately, this doesn't work perfectly as expected.
> The input mode change happens after the first click action, thus
> this always results in grabbing if you do left-click at first, even
> after X starts up and vmmouse gets active.
>
> I thought of checking it via notifier, but the notification happens
> also after the first mouse click event. Hmm.
We could ungrab the pointer if transitioning from relative to absolute mode,
that's effectively what virt-viewer/remote-viewer does (though it also
completely disallows pointer grab in absolute mode... not sure we want to go
that far).
- Cole
- [Qemu-devel] [PATCH v2 0/4] Fix relative pointer tracking on Gtk UI (v2), Takashi Iwai, 2014/04/02
- [Qemu-devel] [PATCH v2 4/4] gtk: Add "Grab On Click" option, Takashi Iwai, 2014/04/02
- Re: [Qemu-devel] [PATCH v2 4/4] gtk: Add "Grab On Click" option, Cole Robinson, 2014/04/02
- Re: [Qemu-devel] [PATCH v2 4/4] gtk: Add "Grab On Click" option, Gerd Hoffmann, 2014/04/02
- [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode, Cole Robinson, 2014/04/02
- Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode, Gerd Hoffmann, 2014/04/02
- Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode, Takashi Iwai, 2014/04/02
- Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode,
Cole Robinson <=
- Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode, Takashi Iwai, 2014/04/03
[Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instead of motion-notify-event, Takashi Iwai, 2014/04/02
[Qemu-devel] [PATCH v2 3/4] gtk: Remember the last grabbed pointer position, Takashi Iwai, 2014/04/02
[Qemu-devel] [PATCH v2 2/4] gtk: Fix the relative pointer tracking mode, Takashi Iwai, 2014/04/02