Re: [Qemu-devel] [PATCH for-2.0? 2/2] cpu-exec: Unlock tb_lock if we longjmp out of code generation

[Peter Maydell]

On 3 April 2014 20:38, Andrei E. Warkentin <address@hidden> wrote:
> Hiya,
>
> Cool. Definitely more compact and less intrusive, and definitely
> should catch more issues than the original page->flags check. The only
> possible cost is maintenance and debugging (implicit state and all
> that)... so... How about adding a comment around the "if
> (have_tb_lock)" to explain how we can get there?

I dunno, it seems fairly obvious to me that if you get to this point
with have_tb_lock true then it must be because you longjumped
out of the codegen. (This happens for softmmu as well as linux-user,
it's just softmmu doesn't actually do any tb locking).

thanks
-- PMM