[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.0 v2 2/2] cpu-exec: Unlock tb_lock if we l
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.0 v2 2/2] cpu-exec: Unlock tb_lock if we longjmp out of code generation |
|
Date: |
Fri, 04 Apr 2014 07:05:38 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/04/2014 04:52 AM, Peter Maydell wrote:
> If the guest attempts to execute from unreadable memory, this will
> cause us to longjmp back to the main loop from inside the
> target frontend decoder. For linux-user mode, this means we will
> still hold the tb_ctx.tb_lock, and will deadlock when we try to
> start executing code again. Unlock the lock in the return-from-longjmp
> code path to avoid this.
>
> Signed-off-by: Peter Maydell <address@hidden>
> Acked-by: Andrei Warkentin <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
r~