Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

[Igor Mammedov]

On Fri, 04 Apr 2014 16:02:32 +0200
Paolo Bonzini <address@hidden> wrote:

> Il 04/04/2014 15:36, Igor Mammedov ha scritto:
> > +    acpi_dev = (acpi_dev = piix4_pm_find()) ? acpi_dev : ich9_lpc_find();
> > +    if (!acpi_dev) {
> > +        error_setg(&local_err,
> > +                   "memory hotplug is not enabled: missing acpi device");
> 
> errp, not &local_err.
> 
> Paolo
>
or better for consistency with th rest of code:
+        goto out;
-        return;
> > +    }
> > +
> 
> 

-- 
Regards,
  Igor