[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 09/10] migration: optimize xbzrle by reducing
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v5 09/10] migration: optimize xbzrle by reducing data copy |
Date: |
Fri, 4 Apr 2014 20:59:01 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
* address@hidden (address@hidden) wrote:
> From: ChenLiang <address@hidden>
>
> Reducing data copy can reduce cpu overhead.
>
> Signed-off-by: ChenLiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
Yes, with the previous patches that's now correct.
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> arch_init.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/arch_init.c b/arch_init.c
> index 84a4bd3..94b62e2 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -373,11 +373,8 @@ static int save_xbzrle_page(QEMUFile *f, uint8_t
> **current_data,
>
> prev_cached_page = get_cached_data(XBZRLE.cache, current_addr);
>
> - /* save current buffer into memory */
> - memcpy(XBZRLE.current_buf, *current_data, TARGET_PAGE_SIZE);
> -
> /* XBZRLE encoding (if there is no overflow) */
> - encoded_len = xbzrle_encode_buffer(prev_cached_page, XBZRLE.current_buf,
> + encoded_len = xbzrle_encode_buffer(prev_cached_page, *current_data,
> TARGET_PAGE_SIZE, XBZRLE.encoded_buf,
> TARGET_PAGE_SIZE);
> if (encoded_len == 0) {
> @@ -396,7 +393,8 @@ static int save_xbzrle_page(QEMUFile *f, uint8_t
> **current_data,
>
> /* we need to update the data in the cache, in order to get the same
> data */
> if (!last_stage) {
> - memcpy(prev_cached_page, XBZRLE.current_buf, TARGET_PAGE_SIZE);
> + xbzrle_decode_buffer(XBZRLE.encoded_buf, encoded_len,
> prev_cached_page,
> + TARGET_PAGE_SIZE);
> }
>
> /* Send XBZRLE based compressed page */
> --
> 1.7.12.4
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v5 00/10] migration: Optimizate the xbzrle and fix one corruption issue, arei.gonglei, 2014/04/04
- [Qemu-devel] [PATCH v5 10/10] migration: clear the dead code, arei.gonglei, 2014/04/04
- [Qemu-devel] [PATCH v5 09/10] migration: optimize xbzrle by reducing data copy, arei.gonglei, 2014/04/04
- Re: [Qemu-devel] [PATCH v5 09/10] migration: optimize xbzrle by reducing data copy,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH v5 03/10] migration: expose the bitmap_sync_count to the end, arei.gonglei, 2014/04/04
- [Qemu-devel] [PATCH v5 05/10] XBZRLE: optimize XBZRLE to decrease the cache misses, arei.gonglei, 2014/04/04
- [Qemu-devel] [PATCH v5 01/10] XBZRLE: Fix one XBZRLE corruption issues, arei.gonglei, 2014/04/04
- [Qemu-devel] [PATCH v5 04/10] migration: expose xbzrle cache miss rate, arei.gonglei, 2014/04/04
- [Qemu-devel] [PATCH v5 06/10] XBZRLE: rebuild the cache_is_cached function, arei.gonglei, 2014/04/04
- [Qemu-devel] [PATCH v5 07/10] xbzrle: don't check the value in the vm ram repeatedly, arei.gonglei, 2014/04/04
- [Qemu-devel] [PATCH v5 02/10] migration: Add counts of updating the dirty bitmap, arei.gonglei, 2014/04/04
- [Qemu-devel] [PATCH v5 08/10] xbzrle: check 8 bytes at a time after an concurrency scene, arei.gonglei, 2014/04/04