[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 96/97] vmstate: Rename VMS_VBUFFER to VMST_VBUFF
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 96/97] vmstate: Rename VMS_VBUFFER to VMST_VBUFFER_INT32 for consintency |
Date: |
Mon, 07 Apr 2014 11:54:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> include/migration/vmstate.h | 6 +++---
>> vmstate.c | 2 +-
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
>> index 976d83e..145c198 100644
>> --- a/include/migration/vmstate.h
>> +++ b/include/migration/vmstate.h
>> @@ -96,7 +96,7 @@ enum VMStateFlags {
>> VMS_BUFFER = 0x020, /* static sized buffer */
>> VMS_ARRAY_OF_POINTER = 0x040,
>> VMS_VARRAY_UINT16 = 0x080, /* Array with size in uint16_t field */
>> - VMS_VBUFFER = 0x100, /* Buffer with size in int32_t field */
>> + VMS_VBUFFER_INT32 = 0x100, /* Buffer with size in int32_t field */
>> VMS_VBUFFER_UINT32 = 0x200, /* Buffer with size in uint32_t field */
>> VMS_VARRAY_UINT8 = 0x400, /* Array with size in uint8_t field*/
>> VMS_VARRAY_UINT32 = 0x800, /* Array with size in uint32_t field*/
>> @@ -436,7 +436,7 @@ extern const VMStateInfo vmstate_info_bitmap;
>> .name = (stringify(_field)), \
>> .size_offset = vmstate_offset_value(_state, _field_size, int32_t),\
>> .info = &vmstate_info_buffer, \
>> - .flags = VMS_VBUFFER|VMS_POINTER, \
>> + .flags = VMS_VBUFFER_INT32|VMS_POINTER, \
>
> Are there any real users of the code where it's really an INT32 value - can
> we just not kill off the silly idea of signed buffer sizes altogether?
>
> (The only case I can follow through is onenand.c that has a PARTIAL_VBUFFER
> based on an 'int' called 'blocks', that's derived during init from an unsigned
> value and passed to things like mallocs and memsets, so it's never going to be
> negative).
There is one user :-(
Note the VARRAY thing, where there are more. And normally it depends on
the target device if it is signed or not
Later, Juan.
- [Qemu-devel] [PATCH 84/97] vmstate: Test for VMSTATE_UINT32_SUB_ARRAY, (continued)
- [Qemu-devel] [PATCH 84/97] vmstate: Test for VMSTATE_UINT32_SUB_ARRAY, Juan Quintela, 2014/04/06
- [Qemu-devel] [PATCH 90/97] vmstate: Test for VMSTATE_BUFFER_UNSAFE, Juan Quintela, 2014/04/06
- [Qemu-devel] [PATCH 91/97] vmstate: Remove unused VMSTATE_SUB_VBUFFER, Juan Quintela, 2014/04/06
- [Qemu-devel] [PATCH 92/97] vmstate: Remove unused VMSTATE_PARTIAL_VBUFFER_UINT32, Juan Quintela, 2014/04/06
- [Qemu-devel] [PATCH 93/97] vmstate: Test for VMSTATE_PARTIAL_VBUFFER, Juan Quintela, 2014/04/06
- [Qemu-devel] [PATCH 89/97] vmstate: Use VMSTATE_UINT8_2DARRAY instead of VMSTATE_BUFFER_TEST, Juan Quintela, 2014/04/06
- [Qemu-devel] [PATCH 94/97] vmstate: ename VMSTATE_PARTIAL_VBUFFER to VMSTATE_VBUFFER_INT32, Juan Quintela, 2014/04/06
- [Qemu-devel] [PATCH 95/97] vmstate: Create VMS_VBUFFER_UINT32, Juan Quintela, 2014/04/06
- [Qemu-devel] [PATCH 96/97] vmstate: Rename VMS_VBUFFER to VMST_VBUFFER_INT32 for consintency, Juan Quintela, 2014/04/06
- [Qemu-devel] [PATCH 97/97] vmstate: Test for VMSTATE_VBUFFER_UINT32, Juan Quintela, 2014/04/06
- [Qemu-devel] [PATCH 85/97] vmstate: Test for VMSTATE_BUFFER, Juan Quintela, 2014/04/07
- [Qemu-devel] [PATCH 87/97] vmstate: Test for VMSTATE_BUFFER_START_MIDDLE, Juan Quintela, 2014/04/07
- [Qemu-devel] [PATCH 88/97] vmstate: Add tests for VMSTATE_BUFFER_TEST, Juan Quintela, 2014/04/07
- [Qemu-devel] [PATCH 86/97] vmstate: Test for VMSTATE_PARTIAL_BUFFER, Juan Quintela, 2014/04/07
- Re: [Qemu-devel] [PATCH for 2.1 00/97] VMState simplification (massive), Dr. David Alan Gilbert, 2014/04/07
- Re: [Qemu-devel] [PATCH for 2.1 00/97] VMState simplification (massive), Marcel Apfelbaum, 2014/04/07