Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

[Marcel Apfelbaum]

On Mon, 2014-04-07 at 15:11 +0300, Michael S. Tsirkin wrote:
> On Mon, Apr 07, 2014 at 02:01:41PM +0200, Gerd Hoffmann wrote:
> > On Mo, 2014-04-07 at 13:59 +0300, Marcel Apfelbaum wrote:
> > > If a pci-2-pci bridge supports hot-plug functionality but there are no 
> > > devices
> > > connected to it, reserve IO/mem in order to be able to attach devices
> > > later. Do not waste space, use minimum allowed.
> > 
> > Makes sense.
> > 
> > > +        u8 shpc_cap = pci_find_capability(s->bus_dev, PCI_CAP_ID_SHPC);
> > 
> > Should we also check for hotplug-capable pci express ports while being
> > at it?
> > 
> > cheers,
> >   Gerd
> > 
> 
> Can be a separate patch?
> 
I think it can be. This one handles pci-2-pci bridges and avoids PCIe by choice.
I do plan to handle PCIe hotplug corners later.

Thanks,
Marcel