Re: [Qemu-devel] [PATCH 1/2] tests-ppc64: add to cleanup rule

[Peter Maydell]

On 14 February 2014 04:03, Alexey Kardashevskiy <address@hidden> wrote:
> Like this? Against what should I rebase my patches and repost them?
>
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 94b32b7..2577843 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -323,7 +323,9 @@ check-block: $(patsubst %,check-%, $(check-block-y))
>  check: check-qapi-schema check-unit check-qtest
>  check-clean:
>         $(MAKE) -C tests/tcg clean
> -       rm -rf $(check-unit-y) $(check-qtest-i386-y)
> $(check-qtest-x86_64-y) $(check-qtest-sparc64-y) $(check-qtest-sparc-y) t
> +       $(eval rmlist = $(check-unit-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y))
> +       $(foreach target,$(SYSEMU_TARGET_LIST), $(eval rmlist +=
> $(check-qtest-$(target)-y)))
> +       rm -rf $(rmlist)

You don't need this intermediate rmlist variable. It should be
possible to do something like
   rm -rf $(foreach target,$(SYSEMU_TARGET_LIST), $(check-qtest-$(target)-y))

(untested!)

thanks
-- PMM