[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.0] Makefile: remove bashism
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.0] Makefile: remove bashism |
|
Date: |
Mon, 7 Apr 2014 17:53:23 +0100 |
On 5 April 2014 15:25, Michael Tokarev <address@hidden> wrote:
> When installing modules (when --enable-modules is specified for
> ./configure), Makefile uses the following construct to replace all
> slashes with dashes in module name:
>
> ${s//\//-}
>
> This is a bash-specific substitution mechanism. POSIX does not
> have it, and some operating systems (for example Debian) does not
> implement this construct in default shell (for example dash).
>
> Use more traditional way to perform the substitution: use `tr' tool.
>
>
> Signed-off-By: Michael Tokarev <address@hidden>
Applied to master, thanks.
-- PMM