qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] block-commit: speed is an optional paramete


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH 2/4] block-commit: speed is an optional parameter
Date: Mon, 07 Apr 2014 20:56:28 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

On 07.04.2014 20:55, Eric Blake wrote:
On 04/07/2014 11:29 AM, Max Reitz wrote:
As speed is an optional parameter for the QMP block-commit command, it
should be set to 0 if not given (as it is undefined if has_speed is
false), that is, the speed should not be limited.

Signed-off-by: Max Reitz <address@hidden>
---
  blockdev.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/blockdev.c b/blockdev.c
index 0be4601..337c11f 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1876,6 +1876,7 @@ void qmp_block_commit(const char *device,
       */
      BlockdevOnError on_error = BLOCKDEV_ON_ERROR_REPORT;
+ speed = speed ? speed : 0;
Oops, branching based on the contents of an undefined variable.  You
meant has_speed in the second of the three uses.

Right – this way, it makes little sense but as a test for compiler optimizations. ;-)

Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]