[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v24 01/31] QemuOpts: move find_desc_by_name ahea
From: |
Leandro Dorileo |
Subject: |
Re: [Qemu-devel] [PATCH v24 01/31] QemuOpts: move find_desc_by_name ahead for later calling |
Date: |
Mon, 7 Apr 2014 22:17:48 -0300 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Apr 03, 2014 at 05:54:19PM +0800, Chunyan Liu wrote:
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Chunyan Liu <address@hidden>
Reviewed-by: Leandro Dorileo <address@hidden>
> ---
> util/qemu-option.c | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/util/qemu-option.c b/util/qemu-option.c
> index 9d898af..e6d10bc 100644
> --- a/util/qemu-option.c
> +++ b/util/qemu-option.c
> @@ -173,6 +173,20 @@ static void parse_option_number(const char *name, const
> char *value,
> }
> }
>
> +static const QemuOptDesc *find_desc_by_name(const QemuOptDesc *desc,
> + const char *name)
> +{
> + int i;
> +
> + for (i = 0; desc[i].name != NULL; i++) {
> + if (strcmp(desc[i].name, name) == 0) {
> + return &desc[i];
> + }
> + }
> +
> + return NULL;
> +}
> +
> void parse_option_size(const char *name, const char *value,
> uint64_t *ret, Error **errp)
> {
> @@ -637,20 +651,6 @@ static bool opts_accepts_any(const QemuOpts *opts)
> return opts->list->desc[0].name == NULL;
> }
>
> -static const QemuOptDesc *find_desc_by_name(const QemuOptDesc *desc,
> - const char *name)
> -{
> - int i;
> -
> - for (i = 0; desc[i].name != NULL; i++) {
> - if (strcmp(desc[i].name, name) == 0) {
> - return &desc[i];
> - }
> - }
> -
> - return NULL;
> -}
> -
> int qemu_opt_unset(QemuOpts *opts, const char *name)
> {
> QemuOpt *opt = qemu_opt_find(opts, name);
> --
> 1.7.12.4
>
--
Leandro Dorileo
- [Qemu-devel] [PATCH v24 00/31] replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/04/03
- [Qemu-devel] [PATCH v24 03/31] qapi: output def_value_str when query command line options, Chunyan Liu, 2014/04/03
- [Qemu-devel] [PATCH v24 09/31] QemuOpts: add qemu_opts_append to replace append_option_parameters, Chunyan Liu, 2014/04/03
- [Qemu-devel] [PATCH v24 05/31] QemuOpts: move qemu_opt_del ahead for later calling, Chunyan Liu, 2014/04/03
- [Qemu-devel] [PATCH v24 04/31] QemuOpts: change opt->name|str from (const char *) to (char *), Chunyan Liu, 2014/04/03