Re: [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08

[Michael Tokarev]

08.04.2014 12:10, Peter Maydell wrote:
> On 8 April 2014 08:04, Michael Tokarev <address@hidden> wrote:
>> And there's a series of 3 patches by Peter Maydell which adds casts
>> to uint* in a few places.  Those are also quite simple and safe, even
>> with quite some disagreement about whenever this is necessary to
>> start with -- I mean the int128 change, the other changes are good.
>> At least this way we make it consistent with other parts of the code.
> 
> I was not expecting those to go in for 2.0...

Well.  At least one of them is entirely safe (hw/ide/ahci.c).
Another - xbzrle.c - looks okay, and even maybe fixing a bug.
And this int128 thing is okay too, except that the whole thing
is questionable as has been mentioned in that thread.

I can prepare another pull request without xbzrle and int128 changes,
or even without ahci change too, but I'm not sure it is worth the
effort - I think everything is okay to go.  I'll take your word for this.

Thanks,

/mjt