Re: [Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option

[Gerd Hoffmann]

On Di, 2014-04-08 at 11:11 +0300, Michael S. Tsirkin wrote:
> On Tue, Apr 08, 2014 at 08:25:34AM +0200, Gerd Hoffmann wrote:
> > On Mo, 2014-04-07 at 23:38 +0300, Michael S. Tsirkin wrote:
> > > On Mon, Apr 07, 2014 at 10:07:43AM +0200, Gerd Hoffmann wrote:
> > > > On Fr, 2014-04-04 at 12:41 +0200, Takashi Iwai wrote:
> > > > > I simply like it better, you don't? :)
> > > > 
> > > > I still think we should make this simply depend on absolute/relative
> > > > pointer mode instead of asking the user to switch it manually.
> > > 
> > > Hmm how do I set absolute/relative mode?
> > 
> > Depends on the pointer input device being used.
> > 
> > Start guest with "-device usb-tablet".  Go to HMP.  'info mice' should
> > list the ps/2 mouse and the usb tablet.  Using 'mouse_set' (or was it
> > set_mouse?) you can force one of the two devides being used.
> > 
> > If you pick the tablet (should be active by default) absolute pointer
> > events are passed to the guest, and qemu works in absolute mode (i.e.
> > sdl doesn't do pointer grabs).
> > 
> > If you pick the mouse relative mouse events are passed to the guest, and
> > qemu works in relative mode (pointer grab is pretty much required to
> > work with the guest).
> > 
> > cheers,
> >   Gerd
> > 
> 
> I have to say grab on click is easier to understand - more predictable.
> Not requesting that it's made the default, but an option would be nice.

Well, usually you'll never ever pick the pointer device manually, this
is mainly meant for testing things or checkout what the behavior is.

Another topic is how to actually activate the grab (when in relative
mode where it is needed).  You surely don't want grab the pointer on
hover as simply crossing the guest window will activate it.
Grab-(+ungrab)-by-hotkey and grab-on-click is what SDL, virt-viewer &
friends are doing today.  I think gtk should simply do the same for
consistency, and I don't see a need for a config option.

cheers,
  Gerd