Re: [Qemu-devel] Should we have a 2.0-rc3 ?

[Ján Tomko]

On 04/10/2014 02:46 PM, Alexander Graf wrote:
> 
> On 10.04.2014, at 14:44, Eric Blake <address@hidden> wrote:
> 
>> On 04/10/2014 05:17 AM, Peter Maydell wrote:
>>> So far I know of at least three fixes which should probably
>>> go into 2.0:
>>> * my fix for the configure stack-protector checks on MacOSX
>>> * MST's pull request updating the ACPI test blobs
>>> * MST says we need to update the hex files for ACPI too
>>>   (otherwise you get a different ACPI blob depending on whether
>>>    your build system had iasl or not, if I understand correctly)
>>>
>>> Are there any others?
>>
>> Yes.  The libvirt team is a bit annoyed that the pci bus naming was
>> changed for PPC but not all architectures, but without a proper QMP
>> command to probe which naming scheme is in effect.  We thought that the
>> naming scheme was going to be universally supplied for all arches, not
>> just PPC.
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg01533.html
>>
>> Is this something that can be quickly fixed (perhaps by reverting the
>> PPC patch until a more complete solution is ready), and if so, is it
>> worth doing for 2.0 proper, rather than waiting for 2.0.1?
> 
> Which way works better for you? I'd be perfectly fine with reverting the 
> patch. Libvirt is the only reason that path is there in the first place.
> 

If I read the git history correctly, there were two patches changing pci bus
names for ppc in this release, not just one:

commit 1b8601b0ea0b91467561e0bbddd52a833e4b2b1a
Author:     Alexey Kardashevskiy <address@hidden>
AuthorDate: 2014-03-06 14:11:00 +1100
Commit:     Andreas Färber <address@hidden>
CommitDate: 2014-03-12 20:13:02 +0100

    spapr-pci: Change the default PCI bus naming

    Previously libvirt required the first/default PCI bus to have name "pci".
    Since QEMU can support multiple buses now, libvirt wants "pci.0" now.

    This removes custom bus name and lets QEMU make up default names.

    Signed-off-by: Alexey Kardashevskiy <address@hidden>
    Signed-off-by: Andreas Färber <address@hidden>

commit 8a0e11045d5f50d300e0ab1ba05f4c8217fb5dcb
Author:     Alexander Graf <address@hidden>
AuthorDate: 2013-12-04 12:42:32 +0100
Commit:     Alexander Graf <address@hidden>
CommitDate: 2013-12-20 01:58:01 +0100

    PPC: Use default pci bus name for grackle and heathrow

    There's no good reason to call our bus "pci" rather than let the default
    bus name take over ("pci.0").

    The big downside to calling it different from anyone else is that tools
    that pass -device get confused. They are looking for a bus "pci.0" rather
    than "pci".

    To make life easier for everyone, let's just drop the name override.

    Signed-off-by: Alexander Graf <address@hidden>

Jan

signature.asc
Description: OpenPGP digital signature