Re: [Qemu-devel] [PATCH v2 1/6] block-commit: Expose granularity

[Max Reitz]

On 08.04.2014 18:20, Eric Blake wrote:
> On 04/08/2014 06:50 AM, Max Reitz wrote:
> > Allow QMP users to manipulate the granularity used in the block-commit
> > command.
> >
> > Signed-off-by: Max Reitz <address@hidden>
> > ---
>
> > +++ b/include/block/block_int.h
> > @@ -426,6 +426,7 @@ void stream_start(BlockDriverState *bs, BlockDriverState 
> > *base,
> >    * @top: Top block device to be committed.
> >    * @base: Block device that will be written into, and become the new top.
> >    * @speed: The maximum speed, in bytes per second, or 0 for unlimited.
> > + * @granularity: The granularity, in bytes, or 0 for a default value.
> >    * @on_error: The action to take upon error.
> >    * @cb: Completion function for the job.
> >    * @opaque: Opaque pointer value passed to @cb.
> > @@ -433,7 +434,7 @@ void stream_start(BlockDriverState *bs, BlockDriverState 
> > *base,
> >    *
> >    */
> >   void commit_start(BlockDriverState *bs, BlockDriverState *base,
> > -                 BlockDriverState *top, int64_t speed,
> > +                 BlockDriverState *top, int64_t speed, int64_t granularity,
> >                    BlockdevOnError on_error, BlockDriverCompletionFunc *cb,
> >                    void *opaque, Error **errp);
> Worth fixing the indentation while you are touching this?

I'm always in favor of code style clean-up. ;-)

Max

> Reviewed-by: Eric Blake <address@hidden>