[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Keyboard/Mouse Console for vfio with active fun
From: |
Alex Williamson |
Subject: |
Re: [Qemu-devel] [PATCH] Keyboard/Mouse Console for vfio with active function x-vga ans -vga none |
Date: |
Thu, 10 Apr 2014 14:29:35 -0600 |
On Thu, 2014-04-10 at 22:07 +0200, qemu Mailinglist wrote:
> there are many discus about using keyboard and mouse with VGA passthru,
> so I add a graphic_console to vfio.c, like puv3.c.
> I test it with SDL and VNC Access, the Keyboard works, the mouse work
> good without absolute version like "-usbdevice mouse".
> Default it boot with "QEMU PS/2 Mouse", but this is changing to "vmmouse
> (absolute)" at boot time of gast system.
>
> I hope someone else can test.
>
> Signed-off-by: Tobias Nannen address@hidden
> ---
> hw/misc/vfio.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
> index 9cf5b84..9294041 100644
> --- a/hw/misc/vfio.c
> +++ b/hw/misc/vfio.c
> @@ -39,6 +39,7 @@
> #include "qemu/range.h"
> #include "sysemu/kvm.h"
> #include "sysemu/sysemu.h"
> +#include "ui/console.h"
>
> /* #define DEBUG_VFIO */
> #ifdef DEBUG_VFIO
> @@ -3586,6 +3587,10 @@ static int vfio_get_device(VFIOGroup *group,
> const char *name, VFIODevice *vdev)
> QLIST_INIT(&vdev->vga.region[QEMU_PCI_VGA_IO_HI].quirks);
>
> vdev->has_vga = true;
> + if (vga_interface_type == VGA_NONE) {
> + static const GraphicHwOps no_ops;
> + graphic_console_init(NULL, 0, &no_ops, NULL);
> + }
> }
> irq_info.index = VFIO_PCI_ERR_IRQ_INDEX;
>
I don't think vfio is the one to be creating a dummy console, besides
there's no reason you can't have multiple vfio devices with x-vga=on.
There should probably be some dummy console driver so you can add
-device dummy-console to the commandline if this is desired. Thanks,
Alex