Re: [Qemu-devel] [PATCH v2 4/4] qemu-options.hx: Update the command line documentation for -device

[Peter Crosthwaite]

On Fri, Apr 11, 2014 at 4:35 PM, Alistair Francis
<address@hidden> wrote:
> Update the command line documentation to include the new sysbus
> connection ability
>
> Signed-off-by: Alistair Francis <address@hidden>
> ---
>
>  qemu-options.hx |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 2d33815..131248b 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -315,8 +315,8 @@ DEF("device", HAS_ARG, QEMU_OPTION_device,
>      "-device driver[,prop[=value][,...]]\n"
>      "                add device (based on driver)\n"
>      "                prop=value,... sets driver properties\n"
> -    "                use '-device help' to print all possible drivers\n"
> -    "                use '-device driver,help' to print all possible 
> properties\n",
> +    "                use '-device help' to print all possible non sysbus 
> drivers\n"

I'm not sure why sysbus devs should be excluded here - is this just a bug?

> +    "                use '-device driver,help' to print all possible non 
> sysbus properties\n",

Any reason this doesn't work?

Regards,
Peter

>      QEMU_ARCH_ALL)
>  STEXI
>  @item -device @var{driver}[,@address@hidden,...]]
> @@ -324,7 +324,9 @@ STEXI
>  Add device @var{driver}.  @address@hidden sets driver
>  properties.  Valid properties depend on the driver.  To get help on
>  possible drivers and properties, use @code{-device help} and
> address@hidden @var{driver},help}.
> address@hidden @var{driver},help}. Valid properties for sysbus devices
> +include: addr and irq.  Which specifies the sysbus device base address
> +and irq number respectivly.
>  ETEXI
>
>  DEF("name", HAS_ARG, QEMU_OPTION_name,
> --
> 1.7.1
>
>