Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

[Alexey Kardashevskiy]

On 04/10/2014 07:24 PM, Daniel P. Berrange wrote:
> On Wed, Mar 05, 2014 at 03:33:39PM +0100, Paolo Bonzini wrote:
>> Il 05/03/2014 15:21, Daniel P. Berrange ha scritto:
>>>> alpha/typhoon.c:    b = pci_register_bus(dev, "pci",
>>>> mips/gt64xxx_pci.c:     phb->bus = pci_register_bus(dev, "pci",
>>>> pci-host/apb.c:    phb->bus = pci_register_bus(DEVICE(phb), "pci",
>>>> pci-host/bonito.c:    phb->bus = pci_register_bus(DEVICE(dev), "pci",
>>>> sh4/sh_pci.c:    phb->bus = pci_register_bus(DEVICE(dev), "pci",
>>>> pci-host/versatile.c:    pci_bus_new_inplace(&s->pci_bus, 
>>>> sizeof(s->pci_bus), DEVICE(obj), "pci",
>>>>
>>>> plus pseries which has its own rules because it supports multiple PCI
>>>> host bridges, but probably can also be changed from "pci" to NULL.
>>>
>>> I'm not sure I understand the effect of changing 'pci' to NULL in this
>>> code, from libvirt's POV. Would using NULL mean we can rely on using
>>> "pci.0" as the default PCI bus name or not ?
>>
>> Yes.  But the next bus that the user creates (e.g. from a PCI bridge
>> without an "id") would be "pci.1" instead of having a duplicate
>> "pci.0").  Needs a bit more testing of course.
> 
> What's the status of this ?  I see the patch merged which only changes
> the bus name for ppc64  spapr-pci board
> 
> commit 1b8601b0ea0b91467561e0bbddd52a833e4b2b1a
> Author: Alexey Kardashevskiy <address@hidden>
> Date:   Thu Mar 6 14:11:00 2014 +1100
> 
>     spapr-pci: Change the default PCI bus naming
> 
> but AFAICT nothing got merged to change this for all the other boards as
> discussed here :-(  This is painful for libvirt since we have todo even
> more hacks triggered off machine names now, instead of being able to
> rely on pci.0 naming as we hoped.

Sorry, I am missing the point.
How could making a platform similar to many others force you to do more
hacks, not less?



-- 
Alexey