qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH microblaze/ppc v2 0/8] Remove include/hw/xilinx.


From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH microblaze/ppc v2 0/8] Remove include/hw/xilinx.h
Date: Mon, 14 Apr 2014 12:19:49 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.4.0


On 25.02.14 09:46, Peter Crosthwaite wrote:
Ping!

Did this get applied meanwhile? Edgar?


Alex


On Thu, Feb 13, 2014 at 9:21 AM, Peter Crosthwaite
<address@hidden> wrote:
Hi Edgar,

This file is written for a very old qdev style of machine description.
Remove by inlining all usages of its functions (which is consistent with
the modern preference that qdev_initery should be inline and not in
cross-board helper functions).

To avoid movement of magic numbers, Define macros for IRQ and memory
maps as appropriate. This cleanup comes first, followed by the
piecewise removal of xilinx.h.

Regards,
Peter


Peter Crosthwaite (8):
   microblaze/s3adsp_1800: Define macros for irq map
   ppc/virtex_ml507: Define macros for irq/memory maps
   microblaze/ml605: Define macros for irq/memory maps
   xilinx: Inline usages of xilinx_intc_create()
   xilinx: Inline usages of xilinx_timer_create()
   xilinx: Inline usage of xilinx_ethlite_create()
   xilinx: Inline usages of xilinx_axi*_init()
   xilinx: Delete hw/include/xilinx.h

  hw/microblaze/petalogix_ml605_mmu.c      | 55 ++++++++++++++-----
  hw/microblaze/petalogix_s3adsp1800_mmu.c | 35 ++++++++++---
  hw/ppc/virtex_ml507.c                    | 29 +++++++---
  include/hw/xilinx.h                      | 90 --------------------------------
  4 files changed, 95 insertions(+), 114 deletions(-)
  delete mode 100644 include/hw/xilinx.h

--
1.8.5.4





reply via email to

[Prev in Thread] Current Thread [Next in Thread]