qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 19/37] target-arm: Implement AArch64 EL1 exce


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v6 19/37] target-arm: Implement AArch64 EL1 exception handling
Date: Mon, 14 Apr 2014 12:26:52 +0100

On 14 April 2014 07:04, Peter Crosthwaite <address@hidden> wrote:
> On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell <address@hidden> wrote:
>> From: Rob Herring <address@hidden>
>> +    switch (cs->exception_index) {
>> +    case EXCP_PREFETCH_ABORT:
>> +    case EXCP_DATA_ABORT:
>> +        qemu_log_mask(CPU_LOG_INT, "...with FAR 0x%" PRIx64 "\n",
>> +                      env->cp15.far_el1);
>
> need a /* fallthrough */

I think a simple 'break;' would be better, actually.

> otherwise:
>
> Reviewed-by: Peter Crosthwaite <address@hidden>

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]