[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 19/37] target-arm: Implement AArch64 EL1 exce
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v6 19/37] target-arm: Implement AArch64 EL1 exception handling |
Date: |
Mon, 14 Apr 2014 12:26:52 +0100 |
On 14 April 2014 07:04, Peter Crosthwaite <address@hidden> wrote:
> On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell <address@hidden> wrote:
>> From: Rob Herring <address@hidden>
>> + switch (cs->exception_index) {
>> + case EXCP_PREFETCH_ABORT:
>> + case EXCP_DATA_ABORT:
>> + qemu_log_mask(CPU_LOG_INT, "...with FAR 0x%" PRIx64 "\n",
>> + env->cp15.far_el1);
>
> need a /* fallthrough */
I think a simple 'break;' would be better, actually.
> otherwise:
>
> Reviewed-by: Peter Crosthwaite <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH v6 00/37] AArch64 system emulation, Peter Maydell, 2014/04/10
- [Qemu-devel] [PATCH v6 16/37] target-arm: Implement SP_EL0, SP_EL1, Peter Maydell, 2014/04/10
- [Qemu-devel] [PATCH v6 33/37] target-arm: Implement Cortex-A57 implementation-defined system registers, Peter Maydell, 2014/04/10
- [Qemu-devel] [PATCH v6 32/37] target-arm: Implement RVBAR register, Peter Maydell, 2014/04/10
- [Qemu-devel] [PATCH v6 34/37] target-arm: Implement CBAR for Cortex-A57, Peter Maydell, 2014/04/10
- [Qemu-devel] [PATCH v6 19/37] target-arm: Implement AArch64 EL1 exception handling, Peter Maydell, 2014/04/10
- [Qemu-devel] [PATCH v6 20/37] target-arm: Implement ARMv8 MVFR registers, Peter Maydell, 2014/04/10
- [Qemu-devel] [PATCH v6 12/37] target-arm: A64: Implement DC ZVA, Peter Maydell, 2014/04/10
- [Qemu-devel] [PATCH v6 27/37] target-arm: Remove THUMB2EE feature from AArch64 'any' CPU, Peter Maydell, 2014/04/10
- [Qemu-devel] [PATCH v6 26/37] target-arm: Implement ISR_EL1 register, Peter Maydell, 2014/04/10
- [Qemu-devel] [PATCH v6 09/37] target-arm: Fix VFP enables for AArch32 EL0 under AArch64 EL1, Peter Maydell, 2014/04/10
- [Qemu-devel] [PATCH v6 01/37] target-arm: Split out private-to-target functions into internals.h, Peter Maydell, 2014/04/10
- [Qemu-devel] [PATCH v6 11/37] target-arm: Don't mention PMU in debug feature register, Peter Maydell, 2014/04/10