Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res'

[Peter Crosthwaite]

On Tue, Apr 8, 2014 at 10:02 PM, Chen Gang <address@hidden> wrote:
> In function, if no additional resources to free before quit, commonly,
> need not use additional local variable 'res' to notice about it. So
> remove it to simplify code.
>

Styling wise, there is a school of thought that functions should only
have one return statement which is probably the original authors
intention.

Regards,
Peter

> Signed-off-by: Chen Gang <address@hidden>
> ---
>  vl.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 7505002..377f962 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1188,18 +1188,16 @@ DeviceState *get_boot_device(uint32_t position)
>  {
>      uint32_t counter = 0;
>      FWBootEntry *i = NULL;
> -    DeviceState *res = NULL;
>
>      if (!QTAILQ_EMPTY(&fw_boot_order)) {
>          QTAILQ_FOREACH(i, &fw_boot_order, link) {
>              if (counter == position) {
> -                res = i->dev;
> -                break;
> +                return i->dev;
>              }
>              counter++;
>          }
>      }
> -    return res;
> +    return NULL;
>  }
>
>  /*
> --
> 1.7.9.5
>