qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] block: prefer protocol_name over format_name in


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH] block: prefer protocol_name over format_name in bdrv_iterate_format
Date: Tue, 15 Apr 2014 15:58:27 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

On 15.04.2014 15:28, Jeff Cody wrote:
Some block drivers have multiple BlockDriver instances with identical
format_name fields (e.g. gluster, nbd).  In those cases, the
protocol_name is usually the more unique identifier (e.g. gluster+tcp).

Both qemu-img and qemu will use bdrv_iterate_format() to list the
supported formats when a help option is invoked.  When just the
format_name is used, redundant listings of formats occur (e.g.,
"Supported formats: ... gluster gluster gluster gluster ... ").

If we prefer the protocol_name over the format_name (when the
protocol name exists), then that provides a more informative
help message:

"Supported formats: ... gluster gluster+tcp gluster+unix
gluster+rdma ... "

Signed-off-by: Jeff Cody <address@hidden>
---
  block.c | 8 +++++++-
  1 file changed, 7 insertions(+), 1 deletion(-)

Reviewed-by: Max Reitz <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]