Re: [Qemu-devel] [PATCH v1 1/3] qdev: Expose the qdev id string as a prop

[Andreas Färber]

Am 15.04.2014 04:21, schrieb Peter Crosthwaite:
> So clients can set the top level id string.
> 
> Signed-off-by: Peter Crosthwaite <address@hidden>

Anthony had nack'ed Paolo's attempt to generalize the qdev id to QOM, so
I'm not sure if we should really do this even if just on device level.
The id= is used to construct the canonical path, and we can't change
that through a qdev setter. Using a dynamic property might allow us to
unparent while keeping a reference and then add it as a child<> again,
but that still feels awkward. Having it as a getter only seem more
secure and predictable.

Another issue is bus naming. If supplied NULL, the bus will be based on
ID. If the ID changes, bus naming will be inconsistent.

Why would clients set the ID after having chosen a different ID or
anonymity?

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg