Re: [Qemu-devel] [PATCH 3/9] s390x: use kvm_enable_cap_vcpu()

[Alexander Graf]

On 14.04.14 18:48, Cornelia Huck wrote:
> Make kvm_s390_enable_css_support() use new interface.
>
> Signed-off-by: Cornelia Huck <address@hidden>

What I was trying to indicate with the "convert users" comment last time 
was to convert non-s390 users :). After all, ENABLE_CAP is a 
cross-architecture interface and we should treat it as such.


Alex

> ---
>   target-s390x/kvm.c |    4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
> index 56b9af7..fbdc1bb 100644
> --- a/target-s390x/kvm.c
> +++ b/target-s390x/kvm.c
> @@ -910,12 +910,10 @@ void kvm_s390_crw_mchk(S390CPU *cpu)
>   
>   void kvm_s390_enable_css_support(S390CPU *cpu)
>   {
> -    struct kvm_enable_cap cap = {};
>       int r;
>   
>       /* Activate host kernel channel subsystem support. */
> -    cap.cap = KVM_CAP_S390_CSS_SUPPORT;
> -    r = kvm_vcpu_ioctl(CPU(cpu), KVM_ENABLE_CAP, &cap);
> +    r = kvm_enable_cap_vcpu(CPU(cpu), KVM_CAP_S390_CSS_SUPPORT);
>       assert(r == 0);
>   }
>