qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] QEMU: ARM: boot: Load kernel at an Image friend


From: Rob Herring
Subject: Re: [Qemu-devel] [PATCH] QEMU: ARM: boot: Load kernel at an Image friendly address
Date: Thu, 17 Apr 2014 11:58:21 -0500

On Thu, Apr 17, 2014 at 5:02 AM, Peter Maydell <address@hidden> wrote:
> On 2 April 2014 13:47, Peter Maydell <address@hidden> wrote:
>> On 2 April 2014 13:11, Peter Crosthwaite <address@hidden> wrote:
>>> Like others, I have been carrying this change locally. Good to see it up!
>>
>> Why are you all booting raw Images anyway (just out of curiosity)?
>
> Given the recent feedback from the kernel mailing list (viz "don't boot
> Image unless you really know what you're doing, the correct load
> image may change randomly depending what other board support
> is in a multikernel image, etc") maybe we should just remove the
> Image booting support instead? Clearly nobody who hasn't locally
> patched QEMU is using it at the moment...

Including AArch64, too? :) It happens to be correct ATM, but really we
should be looking the Image header to determine the offset. I heard
Mark Rutland has some patches to do TEXT_OFFSET randomization in fact.

The choice of 0x10000 is not really a good one either as this forces
the decompressor to move itself out of the way first. I guess it is a
good choice if your goal is to test the worst possible code path for
the decompressor.

Rob



reply via email to

[Prev in Thread] Current Thread [Next in Thread]