Re: [Qemu-devel] [PATCH v2 3/4] block: Catch duplicate IDs in bdrv_new()

[Eric Blake]

On 04/17/2014 09:48 AM, Kevin Wolf wrote:
> Since commit f298d071, block devices added with blockdev-add don't have
> a QemuOpts around in dinfo->opts. Consequently, we can't rely any more
> on QemuOpts catching duplicate IDs for block devices.
> 
> This patch add a new check for duplicate IDs to bdrv_new(), and moves the
> existing check that the ID isn't already taken for a node-name there as
> well.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block.c                    | 11 +++++++++++
>  blockdev.c                 |  6 ------
>  tests/qemu-iotests/087     | 33 +++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/087.out | 13 +++++++++++++
>  4 files changed, 57 insertions(+), 6 deletions(-)

Modulo the commit message Fam pointed out...
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature