qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 002/124] savevm: Remove all the unneded version_


From: Juan Quintela
Subject: Re: [Qemu-devel] [PATCH 002/124] savevm: Remove all the unneded version_minimum_id_old (usb)
Date: Mon, 21 Apr 2014 19:07:38 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Eric Blake <address@hidden> wrote:
> On 04/21/2014 08:39 AM, Juan Quintela wrote:
>
> s/unneded/unneeded/ in the subject
>
>> After previous Peter patch, they are redundant.  This way we don't asign them
>
> s/asign/assign/
>
>> except when needed.  Once there, there were lots of case where the ".fields"
>> indentation was wrong:
>> 
>>      .fields = (VMStateField []) {
>> and
>>      .fields =      (VMStateField []) {
>> 
>> Change all the combinations to:
>> 
>>      .fields = (VMStateField[]){
>> 
>> The biggest problem (appart of aesthetics) was that checkpatch complained
>
> s/appart of/apart from/
>
>> when we copy&pasted the code from one place to another.
>> 
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---


Applied all of your fixes.

Thanks a lot.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]