[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] graphic_console_init: do not receive unneed
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] graphic_console_init: do not receive unneeded error descriptions |
Date: |
Tue, 22 Apr 2014 08:52:13 +0200 |
> > if (dev) {
> > - object_property_set_link(OBJECT(s), OBJECT(dev),
> > - "device", &local_err);
> > - object_property_set_int(OBJECT(s), head,
> > - "head", &local_err);
> > + object_property_set_link(OBJECT(s), OBJECT(dev), "device", NULL);
> > + object_property_set_int(OBJECT(s), head, "head", NULL);
>
> I guess it would be better to use &error_abort rather than failing
> silently.
Agree.
cheers,
Gerd
[Qemu-devel] [PATCH 4/4] PortioList: fix PortioList uses so they do not leak memory, Kirill Batuzov, 2014/04/18
[Qemu-devel] [PATCH 1/4] Replace acpi_pcihp_get_bsel with generic object_property_get_int, Kirill Batuzov, 2014/04/18