qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/4] graphic_console_init: do not receive unneed


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 3/4] graphic_console_init: do not receive unneeded error descriptions
Date: Tue, 22 Apr 2014 08:52:13 +0200

> >     if (dev) {
> > -        object_property_set_link(OBJECT(s), OBJECT(dev),
> > -                                 "device", &local_err);
> > -        object_property_set_int(OBJECT(s), head,
> > -                                "head", &local_err);
> > +        object_property_set_link(OBJECT(s), OBJECT(dev), "device", NULL);
> > +        object_property_set_int(OBJECT(s), head, "head", NULL);
> 
> I guess it would be better to use &error_abort rather than failing
> silently.

Agree.

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]